Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The return of getExecutions does not contain enough information #80

Closed
chrisli30 opened this issue Dec 16, 2024 · 1 comment
Closed
Labels
completed P3 Priority Level 3

Comments

@chrisli30
Copy link
Member

The return of an executions does not contain enough information. If it’s triggered by the block, what block number does the workflow triggered?

AvaProtocol/ava-sdk-js#45

npx jest tests/triggerWorkflow.test.ts -t "trigger for block type should succeed" 

Current result:
expect(executions2.result[0].triggerMetadata?.blockNumber).toEqual(
blockNumber + 5
);

@chrisli30 chrisli30 added the P3 Priority Level 3 label Dec 16, 2024
@v9n
Copy link
Member

v9n commented Dec 27, 2024

The return of an executions does not contain enough information.

It contains all the information in the triggermetadata. I fixed the assertion https://github.com/AvaProtocol/ava-sdk-js/pull/46/files#diff-69d50d249b3bf328b802a6d8cffdc6fd474a0fe1e02555dd3deee2d1f25c0202R103-R106

Other information such as type etc is also in there. Notice the assertion

@v9n v9n added the completed label Dec 27, 2024
@v9n v9n closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed P3 Priority Level 3
Projects
None yet
Development

No branches or pull requests

2 participants