-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take an array of smart wallet as the input of getExecutions, instead of a single smart wallet #71
Comments
Following up, we need a similar array input for listTasks too, so we could use one cursor to control all the results. For example, |
Cursor related: from the below screenshot, we can see that the filter and sorting of column needs to be done by the server side. I don’t think we need them, especially the sorting, now, but here are the feature required. Filter(P2):
Sort(P3):
|
@chrisli30 Agree with listTask. Thinking of same thing. I actually plan for all of this to filter by status and type before and I agree with that.
For sorting, right now we sort by Is the hard requirement to be For sorting by |
Okay, let’s use
Right, status and type should be filters. startedAt needs to be both a filter, and a sorter. The filter will help us to retrieve executions within a week. |
This is done now. We will pass an array to list tasks and get execution. |
Let’s make it,
getExecutions(smartWallets: [], cursor: string, options)
versus
getExecutions(smartWallet, cursor: string, options)
The text was updated successfully, but these errors were encountered: