Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take an array of smart wallet as the input of getExecutions, instead of a single smart wallet #71

Closed
chrisli30 opened this issue Dec 12, 2024 · 5 comments · Fixed by #84
Labels
completed P1 Priority Level 1

Comments

@chrisli30
Copy link
Member

Let’s make it,
getExecutions(smartWallets: [], cursor: string, options)

versus

getExecutions(smartWallet, cursor: string, options)

@chrisli30 chrisli30 added the P1 Priority Level 1 label Dec 12, 2024
@chrisli30
Copy link
Member Author

Following up, we need a similar array input for listTasks too, so we could use one cursor to control all the results. For example,
listTasks([smartWallet1, smartWallet2, smartWallet3], cursor

@chrisli30
Copy link
Member Author

Cursor related: from the below screenshot, we can see that the filter and sorting of column needs to be done by the server side. I don’t think we need them, especially the sorting, now, but here are the feature required.

Filter(P2):

  1. by Status: active, completed, etc.
  2. by completedAt timestamp: using epoch for within last month, or last 3 months

Sort(P3):

  1. By completedAt timestamps: desc by default, but asc could be useful.
  2. By Status: display Active first, then others
  3. Type: by the type of trigger

image (2)

@v9n
Copy link
Member

v9n commented Dec 16, 2024

@chrisli30 Agree with listTask. Thinking of same thing. I actually plan for all of this to filter by status and type before and I agree with that.

Filter(P2):

by Status: active, completed, etc.
by completedAt timestamp: using epoch for within last month, or last 3 months: 

For sorting, right now we sort by started time when a workflow is triggered in asc filter. It has similar effect to completedAt in term of sorting.

Is the hard requirement to be completedAt or startedAt is fine? They has similar effect in term of sorting.

For sorting by status and type, i feel like this should just be filtered ? filter by active/type first, then sort by startedAt normally.

@chrisli30
Copy link
Member Author

chrisli30 commented Dec 17, 2024

Is the hard requirement to be completedAt or startedAt is fine? They has similar effect in term of sorting.

Okay, let’s use startedAt in a desc order.

For sorting by status and type, i feel like this should just be filtered ? filter by active/type first, then sort by startedAt normally.

Right, status and type should be filters.

startedAt needs to be both a filter, and a sorter. The filter will help us to retrieve executions within a week.

@v9n
Copy link
Member

v9n commented Dec 27, 2024

listTasks([smartWallet1, smartWallet2, smartWallet3], cursor
getExecutions(smartWallets: [], cursor: string, options)

This is done now. We will pass an array to list tasks and get execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed P1 Priority Level 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants