Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getKeyRequestMessage for authKey request composing to types package #59

Closed
chrisli30 opened this issue Jan 26, 2025 · 2 comments
Closed

Move getKeyRequestMessage for authKey request composing to types package #59

chrisli30 opened this issue Jan 26, 2025 · 2 comments
Assignees
@chrisli30
Labels
P3 Priority 3 wontfix This will not be worked on

Comments

@chrisli30
Copy link
Member

The function getKeyRequestMessage in packages/sdk-js/src/auth.ts is light-weight, just a string template. We should move it to types package so frontend could access it directly.
@chrisli30 chrisli30 added P3 Priority 3 P2 Priority 2 and removed P3 Priority 3 labels Jan 26, 2025
@chrisli30 chrisli30 added wontfix This will not be worked on P3 Priority 3 and removed P2 Priority 2 labels Feb 5, 2025
@chrisli30
Copy link
Member Author

The function is now moved to the backend of the Studio, so it’s not causing http2 reference problem at the moment.

@chrisli30 chrisli30 self-assigned this Feb 7, 2025
@chrisli30
Copy link
Member Author

Fixed by #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisli30 chrisli30

Labels
P3 Priority 3 wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisli30