-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logic For Rewriting URLs in JSON Response for Proxy #351
Comments
We only need to bump the version of node-http-proxy-json. Looks like the one that was used was really old. |
I suggest reverting 281a2d7 and just bumping the version of node-http-proxy-json. |
Still no dice on that https://github.com/langjt/node-http-proxy-json/blob/master/index.js#L22-L24 langjt/node-http-proxy-json#10 We will have to manually change the |
I don't see any manual change of the |
I think |
🚀 Feature request
Current Behavior
Any JSON response that comes back with contains a URL that points to the
targetHost
will not work if clicked via some Link component on an app because it will not be relative tolocalhost
when developing.Desired Behavior
The proxy should intercept the response before it reaches the UI, modify the URLs, if any exist, and then send it to the UI.
Suggested Solution
node-http-proxy-json looks to update this however, its not modifying the
content-length
which is why we had to revert #314Example
With
targetHost
ofhttp://www.helloworld.com
Should get modified to:
Once we can get the
content-length
updated it should work for all types of API responses.Additional context
#350
The text was updated successfully, but these errors were encountered: