feat(api-core): helper function for settings api #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested changes
Aug 22, 2018
| @@ -15,5 +17,41 @@ export default class AvSettings extends AvApi { | |||
| merge, | |||
| config: options, | |||
| }); | |||
| this.avUsers = avUsers; | |||
There was a problem hiding this comment.
Probably should throw if avUser is not provided here.
Or throw in the methods where it is used so that the other methods can still be used without needing it (maybe a less breaking change).
There was a problem hiding this comment.
I added it to the other implementations, that pattern makes sense but might be worth saving for a refactor PR for all the other apis with similar dependencies.
There was a problem hiding this comment.
@KaseyPowers changes LGTM. Can you open a ticket with the refactor suggestions?
robmcguinness
approved these changes
Aug 22, 2018
TheSharpieOne
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.