Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-weight appears to recognise only normal and bold #33

Open
kuiperzone opened this issue Oct 4, 2023 · 10 comments
Open

font-weight appears to recognise only normal and bold #33

kuiperzone opened this issue Oct 4, 2023 · 10 comments

Comments

@kuiperzone
Copy link

The CSS style font-weight:400; generates bold. It would be nice if this recognised numbers.

@maxkatz6
Copy link
Member

maxkatz6 commented Oct 4, 2023

HtmlRenderer adapter layer has only these values:
https://github.com/ArthurHub/HTML-Renderer/blob/a004aefeb87b5226aece75c49e84040dbaf9f3e0/Source/HtmlRenderer/Adapters/Entities/RFontStyle.cs#L21-L28

We should stop using the original repo as a submodule, and instead copy-paste its source code to this repo. Allowing us to fix these problems.

@kuiperzone
Copy link
Author

Thank you. That's good to know. Think the render is a brilliant control, though it's support may be a tad limited.

@kuiperzone
Copy link
Author

The demo is not the easiest thing to build, even after installing all the workloads. Is there a pre-built desktop demo (either Windows or Linux)?

@maxkatz6
Copy link
Member

maxkatz6 commented Oct 4, 2023

You can unload mobile projects, then it should be fine. Or you can build Desktop project specifically, without building mobile projects.

@kuiperzone
Copy link
Author

What's meant to be in "external"?

image

@kuiperzone
Copy link
Author

I'm guessing this might be a clue?

image

@maxkatz6
Copy link
Member

maxkatz6 commented Oct 4, 2023

You need to clone submodules as well:

git submodule init 
git submodule update

@Gillibald
Copy link

Ideally we directly fork the original project to be able to make changes to it

@maxkatz6
Copy link
Member

@kuiperzone I just rebased fork onto this repository, so both code bases are combined in this repo. Now it should be possible to make any changes and send PRs.
We are not very familiar with the original HtmlRenderer code base, but I can help reviewing if you can send any fixes/features. Possibly some PRs can be ported from https://github.com/ArthurHub/HTML-Renderer/pulls.

@kuiperzone
Copy link
Author

That's great. Just raising issues as I find them so there is some record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants