Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImplicitAnimations don't work for the first three changes #15254

Closed
laolarou726 opened this issue Apr 6, 2024 · 4 comments
Closed

ImplicitAnimations don't work for the first three changes #15254

laolarou726 opened this issue Apr 6, 2024 · 4 comments

Comments

@laolarou726
Copy link
Contributor

Describe the bug

ImplicitAnimations don't work for the first three changes.
Furthermore, when setting the animation key for the ImplicitAnimations, if the key name does not equal the property that is going to animate. The ImplicitAnimations will not work at all.

For example:

var ani = compositor.CreateVector3KeyFrameAnimation();

ani.Target = "Offset";
ani.InsertExpressionKeyFrame(1f, "this.FinalValue", easing);
ani.Duration = TimeSpan.FromMilliseconds(445);

visual.ImplicitAnimations ??= compositor.CreateImplicitAnimationCollection();

visual.ImplicitAnimations["Offset"] = ani; // animation will work but still buggy
visual.ImplicitAnimations["A_RANDOM_NAME"] = ani; // not working at all

gif

To Reproduce

See repro: https://github.com/laolarou726/CompositionBug
Also see issue: #15096

Expected behavior

All the animations should work for every value change and trigger.

Avalonia version

latest nightly

OS

Windows

Additional context

No response

@lindexi
Copy link
Contributor

lindexi commented Oct 28, 2024

@laolarou726
Copy link
Contributor Author

@laolarou726 Your https://github.com/laolarou726/CompositionBug is 404

Sorry, that was a mistake. Now restored!

@lindexi
Copy link
Contributor

lindexi commented Oct 28, 2024

Thank you @laolarou726

I fixed your issues in #17370

@laolarou726
Copy link
Contributor Author

Thank you @laolarou726

I fixed your issues in #17370

LGTM! Thank you so much for your help on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants