Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform configuration refactoring #2365

Closed
kekekeks opened this issue Mar 11, 2019 · 0 comments
Closed

Platform configuration refactoring #2365

kekekeks opened this issue Mar 11, 2019 · 0 comments

Comments

@kekekeks
Copy link
Member

Right now if one wants to change initialization options for a particular platform, it's needed to explicitly initialize it with UseXXX method on app builder. Options are passed using positional arguments. This approach has two issues:

  1. UsePlatformDetect can't be used anymore
  2. ABI compatibility is broken when new parameters are added

What I think we should do instead is to register options for a particular platform in app builder before calling platform detect. E. g.:

AppBuilder.Configure<App>()
      .With(new Win32Options { UseEgl = true, UseDeferredRenderer = false }
      .With(new MacOptions { ShowInDock = false })
      .UsePlatformDetect();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant