Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all TemplateParts to Match Convention #8057

Closed
robloo opened this issue Apr 30, 2022 · 5 comments · Fixed by #8793
Closed

Update all TemplateParts to Match Convention #8057

robloo opened this issue Apr 30, 2022 · 5 comments · Fixed by #8793
Labels

Comments

@robloo
Copy link
Contributor

robloo commented Apr 30, 2022

Describe the bug

Certain controls do not properly name their template parts. These should be renamed to follow convention before the 11.0 release as it is a breaking change for the styles.

This is the breaking-change following PR #7911 and #7994.

Also discussed in #7432

I will also close this one, just adding to keep track of it.

Expected behavior

All template parts should start with the "PART_" prefix as is done in WPF and most controls.

Screenshots

N/A

Desktop (please complete the following information):

  • OS: [e.g. Windows, Mac, Linux (State distribution)]
  • Version [e.g. 0.10.0-rc1 or 0.9.12]

Additional context
Add any other context about the problem here.

@robloo robloo added the bug label Apr 30, 2022
@robloo
Copy link
Contributor Author

robloo commented Jun 24, 2022

@Takoooooo @maxkatz6

I'm waiting on the big styling updates branch to be merged before I do this. However, it still needs to be done before 11.0. If you want, just let me know a good time to open a PR and I can do this quickly.

@maxkatz6
Copy link
Member

Yes, it should be done after control theme changes, otherwise huge conflicts are unavoidable.
Also, not really necessary to have this done in first preview versions.

@robloo
Copy link
Contributor Author

robloo commented Aug 10, 2022

Now that all the control theme updates are made, I'm going to go through and update template parts within the next week or so.

@robloo
Copy link
Contributor Author

robloo commented Aug 10, 2022

Adding link to a specific discussion: #3538 (comment)

@robloo
Copy link
Contributor Author

robloo commented Aug 21, 2022

Well, I had no visibility on the Preview 1 release date or I would have got this in. However, there is a draft PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants