-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all TemplateParts to Match Convention #8057
Comments
I'm waiting on the big styling updates branch to be merged before I do this. However, it still needs to be done before 11.0. If you want, just let me know a good time to open a PR and I can do this quickly. |
Yes, it should be done after control theme changes, otherwise huge conflicts are unavoidable. |
Now that all the control theme updates are made, I'm going to go through and update template parts within the next week or so. |
Adding link to a specific discussion: #3538 (comment) |
Well, I had no visibility on the Preview 1 release date or I would have got this in. However, there is a draft PR now. |
Describe the bug
Certain controls do not properly name their template parts. These should be renamed to follow convention before the 11.0 release as it is a breaking change for the styles.
This is the breaking-change following PR #7911 and #7994.
Also discussed in #7432
I will also close this one, just adding to keep track of it.
Expected behavior
All template parts should start with the "PART_" prefix as is done in WPF and most controls.
Screenshots
N/A
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: