-
Notifications
You must be signed in to change notification settings - Fork 270
Run mypy on full library #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@marcharper I think the latest release of mypy might have the fix but I'm not sure, I've tried running things locally:
Runs fine without errors but it doesn't report failures (I've tested this by breaking type hints and they're failing silently). If you could take another look to see if it's just me that'd be great. We've missed at least 1 module in PRs (the |
I confirm no errors running the latest mypy with our master or the Errors are reported with |
Ah, but errors are reported there on There's no way (yet) to replace our |
I think so. |
@marcharper found a bug in mypy but this has now been patched: python/mypy#2786
This bug currently stops us from type checking the whole library (as some modules don't play nice) so
type_tests.sh
type checks each relevant module.When mypy next does a release we should update
type_tests.sh
(or get rid of it and simply run the required command intravis.yml
?).We should also add the corresponding mypy command to the docs.
The text was updated successfully, but these errors were encountered: