Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network service doesn't notice when Ethernet appears #443

Closed
agriffis opened this issue Jun 3, 2024 · 1 comment
Closed

network service doesn't notice when Ethernet appears #443

agriffis opened this issue Jun 3, 2024 · 1 comment

Comments

@agriffis
Copy link
Contributor

agriffis commented Jun 3, 2024

My laptop doesn't have Ethernet, but my dock does. This means that I have an NM.DeviceEthernet that comes and goes.

When I plug in my dock, ags doesn't handle the change. This is because the network service only calls new Wired(this._getDevice(NM.DeviceType.ETHERNET) as NM.DeviceEthernet) once when it is initialized.

I think that handling this properly would involve some rewriting in network.ts. Is it worth digging into since you're already working on the rewrite in vala?

@Aylur
Copy link
Owner

Aylur commented Jun 20, 2024

any help with network is appreciated, since its still nm, I can just translate any typescript to vala once I get to it

@Aylur Aylur mentioned this issue Sep 25, 2024
Merged
@Aylur Aylur closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants