-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add support for InfoWindow headerContent / headerDisabled options #378
[Feat] Add support for InfoWindow headerContent / headerDisabled options #378
Comments
Currently this only happens with the beta version of the maps API, so we still have a bit of time.. |
Actually I am working with the API in the weekly version. I changed it to monthly to get the older version. Thanks! |
This already made it to weekly? |
Same here!! I think this is extremely important! |
For anyone facing this, you can temporary fix the empty space at the top using css: .gm-style-iw-chr {
position: absolute;
display: flex;
top: 0;
right: 0;
}
.gm-style-iw.gm-style-iw-c {
padding-top: 14px !important;
} |
The As for Option 1: Render callback (
|
I like option 2, given that |
I'm mostly sceptical about option 3 since that would involve some sort of accessing portals within (or out of?) portals, and I have no Idea if that causes problems, but It's complicated to just think about. I'd be willing to figure it out if majority says that's the better solution, but we'll see... |
Starting with the current beta-version, the Maps API will add new options to control content and visibility of the InfoWindow-header. This adds a new headerContent prop that renders JSX content into the InfoWindows header. fixes visgl#378
Starting with the current beta-version, the Maps API will add new options to control content and visibility of the InfoWindow-header. This adds a new headerContent prop that renders JSX content into the InfoWindows header. fixes visgl#378
Starting with the current beta-version, the Maps API will add new options to control content and visibility of the InfoWindow-header. This adds a new headerContent prop that renders JSX content into the InfoWindows header. fixes #378
This is what I did, based on messages above in this thread: |
Target Use Case
Currently in beta in the Maps JavaScript API, there will be new options for the InfoWindow, finally allowing users to disable the header including the close-button and to specify separate html for the header of the infowindow. These should be supported here as well.
Proposal
Add new props
headerContent
andheaderDisabled
for theInfoWindow
component. While headerDisabled is just a boolean, headerContent can be arbitrary html, so we should support that via a render-callback, rendering the content into a portal.The text was updated successfully, but these errors were encountered: