Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block indices DB should store ranges of blocks instead of individual block numbers #10573

Closed
PhilWindle opened this issue Dec 10, 2024 · 0 comments · Fixed by #10658
Closed

Block indices DB should store ranges of blocks instead of individual block numbers #10573

PhilWindle opened this issue Dec 10, 2024 · 0 comments · Fixed by #10658
Assignees
@PhilWindle
Milestone
TestNet

Comments

@PhilWindle
Copy link
Collaborator

The block indices database used in the world state allows for multiple block numbers to be at the same index (zero size blocks). It does this by storing a vector of block numbers against the index. This should be changed to storing a start and end block number as the block numbers are always consecutive.
@PhilWindle PhilWindle added this to the TestNet milestone Dec 10, 2024
@PhilWindle PhilWindle self-assigned this Dec 10, 2024
@PhilWindle PhilWindle added this to A3 Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 10, 2024
@PhilWindle PhilWindle linked a pull request Dec 12, 2024 that will close this issue
feat: Don't store every block number in block indices DB #10658
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilWindle PhilWindle

Labels
None yet
Projects
A3
Archived in project
Milestone
TestNet
Development

Successfully merging a pull request may close this issue.

feat: Don't store every block number in block indices DB AztecProtocol/aztec-packages
1 participant
@PhilWindle