feat: generating Noir constants #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
janb/generating-noir-constants
branch
from
ce96a86 to
5b6e57c
Compare
ludamad
reviewed
Jul 14, 2023
| global ARGS_LENGTH: comptime Field = 16; | ||
| global RETURN_VALUES_LENGTH: comptime Field = 4; | ||
| global READ_REQUESTS_LENGTH: comptime Field = 4; | ||
| global MAX_NEW_COMMITMENTS_PER_CALL: comptime Field = 4; |
There was a problem hiding this comment.
Not sure about some of these GENERATOR__ names but looks good to me
There was a problem hiding this comment.
I felt like prefixing it with enum name is the best solution given that there are no native enums in Noir. Kev told me that enums can be approximated with structs but that seems like unnecessary complexity to me.
Or would you prefer some other prefix?
ludamad
reviewed
Jul 14, 2023
| @@ -50,7 +50,7 @@ impl<Note, N, S, P> NoteGetterOptions<Note, N, S, P> { | |||
| } | |||
|
|
|||
| fn with_filter( | |||
| filter: fn ([Note; MAX_READ_REQUESTS], P) -> [Note; S], | |||
There was a problem hiding this comment.
hmm, this seems like it should still have MAX in the name, not sure how to reconcile that
There was a problem hiding this comment.
maybe if some of the constants went into a limits crate and we had limits::READ_REQUESTS_LENGTH
ludamad
approved these changes
Jul 14, 2023
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1065
Checklist: