Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack notes in logs instead of serializing them #11375

Closed
benesjan opened this issue Jan 21, 2025 · 0 comments · Fixed by #11376
Closed

Pack notes in logs instead of serializing them #11375

benesjan opened this issue Jan 21, 2025 · 0 comments · Fixed by #11376
Labels
team-fairies Nico's team

Comments

@benesjan
Copy link
Contributor

benesjan commented Jan 21, 2025

Currently we serialize notes instead of packing them. This results in a large DA cost for logs (e.g. value represented as U128 in UintNote gets serialized as 2 fields).

Instead we should create a copy of the flatten_to_fields function that uses the Packable trait and tightly packs the note content.

@benesjan benesjan added the team-fairies Nico's team label Jan 21, 2025
@nventuro nventuro changed the title Pack notes instead of serializing them Pack notes in logs instead of serializing them Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-fairies Nico's team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant