Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs github mirror action #1145

Merged
merged 3 commits into from
Jul 22, 2023
Merged

fix: docs github mirror action #1145

merged 3 commits into from
Jul 22, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jul 21, 2023

Description

Should fix master.

The action had failed in master asking for identity. As well, I noticed that if the subrepo is updated, and then a commit squashed, the parent might become not a real commit. I kludged a fix for a squash workflow by finding the parent commit of where the file was edited last.

Checklist:

  • [*] I have reviewed my diff in github, line by line.
  • [*] Every change is related to the PR description.
  • [*] I have linked this pull request to the issue(s) that it resolves.
  • [*] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • [*] The branch has been merged or rebased against the head of its merge target.
  • [*] I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad ludamad force-pushed the ad/fix/mirror-runner branch from 16f5b1c to 825cbfa Compare July 21, 2023 21:38
@ludamad ludamad changed the title fix: github mirror action fix: docs github mirror action Jul 21, 2023
@ludamad ludamad force-pushed the ad/fix/mirror-runner branch 8 times, most recently from 17d73a7 to 3035329 Compare July 22, 2023 01:30
@ludamad ludamad force-pushed the ad/fix/mirror-runner branch from 3035329 to 23dfc30 Compare July 22, 2023 01:31
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@dbanks12 dbanks12 merged commit b753ae7 into master Jul 22, 2023
@dbanks12 dbanks12 deleted the ad/fix/mirror-runner branch July 22, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants