Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow noir-libs to be a dependency of external Noir Contracts #1335

Closed
iAmMichaelConnor opened this issue Aug 1, 2023 · 3 comments
Closed
Assignees
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex)

Comments

@iAmMichaelConnor
Copy link
Contributor

Currently, to use our standard library of Aztec contract helper functions and structs, you need to develop your contract inside aztec-packages, by specifying the relative path in the contract's Nargo.toml.

Alternatively, Nargo also allows a GitHub url of the dependency to be provided, but the Nargo.toml of the dependency must be at the top level of the repo (whereas our noir lib is currently nested inside yarn-project/).

Corresponding issue created in Noir-Lang here.

@iAmMichaelConnor iAmMichaelConnor added the A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) label Aug 1, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 1, 2023
@dbanks12
Copy link
Collaborator

dbanks12 commented Aug 8, 2023

Assigning to @sirasistant as @iAmMichaelConnor and @LeilaWang requested.

@sirasistant
Copy link
Collaborator

If we finally go with noir-compiler for compilation, we should support git dependencies on it. Shouldn't be too bad 🤞

@sirasistant
Copy link
Collaborator

PR in noir noir-lang/noir#2436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex)
Projects
Archived in project
Development

No branches or pull requests

3 participants