Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address panic in safe_math test #2000

Closed
LHerskind opened this issue Sep 5, 2023 · 4 comments
Closed

Address panic in safe_math test #2000

LHerskind opened this issue Sep 5, 2023 · 4 comments
Labels
S-blocked Status: Blocked

Comments

@LHerskind
Copy link
Contributor

As mentioned in #1967 and in Slack, including a mod 0 operation will cause panic even if an assert should have failed earlier.

This issue is made to solve that problem, and keep track of it separate to #1965 such that we can get the primary testing in.

@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 5, 2023
@LHerskind LHerskind added the S-blocked Status: Blocked label Sep 5, 2023
@LHerskind
Copy link
Contributor Author

@kevaundray @Savio-Sou this issue is purely noir related, so might be more on your terms.

@Savio-Sou
Copy link
Member

Savio-Sou commented Sep 6, 2023

Thanks @LHerskind!

Not sure if I fully follow on the context and how to reproduce. Would you like to create an Issue on https://github.com/noir-lang/noir/issues/?

@LHerskind
Copy link
Contributor Author

Not sure if I fully follow on the context and how to reproduce. Would you like to create an Issue on https://github.com/noir-lang/noir/issues/?

Added noir-lang/noir#2572

@Savio-Sou
Copy link
Member

Closed with noir-lang/noir#2578.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked
Projects
Archived in project
Development

No branches or pull requests

2 participants