-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IAC for a prototype devnet #2720
Conversation
resource_class: large | ||
steps: | ||
- *checkout | ||
- *setup_env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be built by yarn-project I think. You would be able to grab the build from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't yarn-project just produce a single image yarn-project
with all of the built code? And if we want an actual deployable package image we need to have a Dockerfile which extracts the relevant built code for that package?
Benchmark resultsAll benchmarks are run on txs on the L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm curious as to why put the p2p ports behind the load balancer. I'd've expected to see just the node API behind the lb, so requests would be routed to whatever node was available, but letting the nodes p2p ports and the p2p bootstrap node be directly reachable from the internet without having to go through the lb. Or is it meant to test a NAT-like setup?
Yes, it's testing a NAT setup. The services are in a private subnet with the lb performing port-forwarding. Note, we actually have 2 load balancers in the system. There is an Application Load Balancer that isn't defined here. It's part of the As we build databases and stuff out, having everything in a private subnet makes sense I feel and I also wanted to verify libp2p's announcing mechanism. |
This PR contains some CI and Terraform work to deploy an initial devnet.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.