Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(aztec-nr): compiler should error when no compute_note_hash_and_nullifier is provided #2738

Closed
Maddiaa0 opened this issue Oct 9, 2023 · 1 comment · Fixed by noir-lang/noir#3216
Labels
T-feedback Type: recording user feedback

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Oct 9, 2023

Overview

Currently compilation does not fail if private state is used and the compute_note_hash_and_nullifier method is not included.
The aztec flavour of noir should offer some warning / error that causes this issue to be caught at compile time rather than at runtime.

image

@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 9, 2023
@Maddiaa0 Maddiaa0 changed the title fix(aztec-nr): compiler should error when no compute_note_hash_and_nullifier is provided bug(aztec-nr): compiler should error when no compute_note_hash_and_nullifier is provided Oct 9, 2023
@spalladino spalladino added the T-feedback Type: recording user feedback label Oct 9, 2023
@spalladino
Copy link
Collaborator

Reported by @0xShaito from Wonderland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feedback Type: recording user feedback
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants