Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix rebuild pattern slashes. #2843

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented Oct 13, 2023

A broken approach had been taken to our rebuild patterns.
They were not actually regular expressions, as they had had double backslashes inserted in order to handle the fact that awk in "awk -v" mode requires c-string style patterns, which means the slashes needed to be escaped.
This meant the patterns didn't work right in any other regex context such as when using "grep -E".
This fix normalises the patterns into standard regex format, and in content hash generation, we now perform the escaping of slashes there for awk.

@charlielye charlielye changed the title Fix rebuild pattern slashes. fix: Fix rebuild pattern slashes. Oct 13, 2023
@charlielye charlielye requested a review from ludamad October 13, 2023 11:58
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5585075f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 223,020 868,328 3,449,444
l1_rollup_execution_gas 842,107 3,595,436 22,204,813
l2_block_processing_time_in_ms 1,072 (+5%) 4,047 (+3%) 16,072 (+6%)
note_successful_decrypting_time_in_ms 342 (+6%) 1,058 (+7%) 3,823 (+7%)
note_trial_decrypting_time_in_ms ⚠️ 43.0 (+65%) 109 (+10%) 138
l2_block_building_time_in_ms 9,214 (+3%) 36,780 (+2%) 156,562 (+5%)
l2_block_rollup_simulation_time_in_ms 6,868 (+4%) 27,365 (+3%) 109,318 (+4%)
l2_block_public_tx_process_time_in_ms 2,305 (+2%) 9,283 (+2%) 46,742 (+8%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,196 (+1%) 30,726
note_history_successful_decrypting_time_in_ms 2,363 (+4%) 4,717 (+6%)
note_history_trial_decrypting_time_in_ms 123 (+2%) ⚠️ 153 (-26%)
node_database_size_in_bytes 1,647,582 1,191,891
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 44.5 (+3%) 56,577 14,745
private-kernel-ordering 21.5 (+1%) 20,137 8,089
base-rollup 854 631,605 811
root-rollup 38.2 (-1%) 4,072 1,097
private-kernel-inner 36.9 (+4%) 72,288 14,745
public-kernel-private-input 47.9 (+2%) 37,359 14,745
public-kernel-non-first-iteration 28.7 (+2%) 37,401 14,745
merge-rollup 0.848 (-2%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,094

@charlielye charlielye merged commit e32517e into master Oct 13, 2023
@charlielye charlielye deleted the cl/fix_rebuild_pattern_slashes branch October 13, 2023 13:24
charlielye added a commit that referenced this pull request Oct 17, 2023
charlielye added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants