fix: Fix rebuild pattern slashes. #2843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A broken approach had been taken to our rebuild patterns.
They were not actually regular expressions, as they had had double backslashes inserted in order to handle the fact that awk in "awk -v" mode requires c-string style patterns, which means the slashes needed to be escaped.
This meant the patterns didn't work right in any other regex context such as when using "grep -E".
This fix normalises the patterns into standard regex format, and in content hash generation, we now perform the escaping of slashes there for awk.