Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(AztecNr): Inconsistent snake_case and CamelCase #3171

Closed
Tracked by #2783
ludamad opened this issue Nov 1, 2023 · 2 comments
Closed
Tracked by #2783

refactor(AztecNr): Inconsistent snake_case and CamelCase #3171

ludamad opened this issue Nov 1, 2023 · 2 comments
Assignees
@sklppy88

Comments

@ludamad
Copy link
Collaborator

ludamad commented Nov 1, 2023

We should do a regex-powered sweep and change all the current casings
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 1, 2023
@LHerskind LHerskind mentioned this issue Mar 9, 2024
Open
@LHerskind LHerskind changed the title aztec.nr: Inconsistent snake_case and CamelCase refactor(AztecNr): Inconsistent snake_case and CamelCase Mar 9, 2024
@sklppy88 sklppy88 self-assigned this Mar 18, 2024
@sklppy88
Copy link
Contributor

I've looked w/ both regex + manually into noir-projects/aztec-nr and noir-protocol-circuits and it seems like everything is fine 🙏. Seems like this refactor was already done. We can reopen this if I've missed anything.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 19, 2024
@sklppy88
Copy link
Contributor

sklppy88 commented Mar 21, 2024 •
edited
Loading

Was looking into this one again, turns out my regex searching in vscode wasn't actually taking into account casing due to an oversight with the regex mode. Will address. This is a duplicate of #1928 though so I'll leave this closed and use the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludamad @sklppy88