Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch up note processors could be synced more efficiently #3683

Closed
alexghr opened this issue Dec 13, 2023 · 0 comments · Fixed by #3933
Closed

Catch up note processors could be synced more efficiently #3683

alexghr opened this issue Dec 13, 2023 · 0 comments · Fixed by #3933
Assignees
@just-mitch

Comments

@alexghr
Copy link
Contributor

alexghr commented Dec 13, 2023

In the PXE's synchronizer, the note processors in catch up mode are synced one by one. This means the same block will be read multiple times, once for each note processors catching up. A better approach would be to groups note processors by the block they need and synchronizing them in bulk.
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 13, 2023
@just-mitch just-mitch linked a pull request Jan 10, 2024 that will close this issue
chore: catch up note processors could be synced more efficiently #3933
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 11, 2024
@alexghr alexghr removed their assignment Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@just-mitch just-mitch

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: catch up note processors could be synced more efficiently AztecProtocol/aztec-packages
2 participants
@alexghr @just-mitch