Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Custom note syntax and note selector #4126

Closed
3 tasks done
LHerskind opened this issue Jan 18, 2024 · 2 comments
Closed
3 tasks done

Feat: Custom note syntax and note selector #4126

LHerskind opened this issue Jan 18, 2024 · 2 comments
Labels
T-tracking Type: Tracking Issue. This contains tasklists.
Milestone
Execution Environ...

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jan 18, 2024 •
edited
Loading

Tasks
Preview Give feedback
  1. Create a macro that injects compute_note_hash_and_nullifier #2918
    nventuro
  2. Support private Maps of different note types in the same contract in compute_hash_and_nullifier #2820
    T-feedback
    nventuro
  3. Refactor: Improve clarity of note syntax #4199
    LHerskind
@LHerskind LHerskind added the T-tracking Type: Tracking Issue. This contains tasklists. label Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 18, 2024
@LHerskind LHerskind added this to the Execution Environment milestone Jan 22, 2024
@rahul-kothari
Copy link
Contributor

  • Traits/macros to remove boilerplate methods
  • change lifecycle to make it easier to follow what is going on e.g. nullifier isn't really the actual nullifier that gets added etc.
  • Spike: Apparently the YP mentiones notes will be hashed in a separate way such that PXE will know which broadcasts are for the notes?

@LHerskind
Copy link
Contributor Author

Closing this as the subtasks have been finished. If to be updated or extended, feel free to open the issue again.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-tracking Type: Tracking Issue. This contains tasklists.
Projects
A3
Archived in project
Milestone
Execution Environment pre offsite
Development

No branches or pull requests
2 participants
@LHerskind @rahul-kothari