Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various manual fixes/tweaks in preparation for clang-tidy PR #415

Merged
merged 7 commits into from
Apr 29, 2023

Conversation

dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Apr 29, 2023

Description

Blocks #393

  • Adds clang-format/clang-tidy/clangd configuration files and a helper script for tidying
  • Fixes code that actually breaks clang-tidy (auto-fixes lead to compilation errors without these manual fixes)

The purpose of this intermediate/separate PR is that individuals can merge just this patch into their branches so they can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
Copy link
Collaborator

ludamad commented Apr 29, 2023

LGTM (so far)

@dbanks12 dbanks12 marked this pull request as ready for review April 29, 2023 15:23
@dbanks12
Copy link
Contributor Author

Thanks @ludamad. Just flagged it as ready after pushing the actual clang-format/clang-tidy/clangd configurations and the script for tidying. This PR fixes code that actually breaks clang-tidy (auto-fixes lead to compilation errors without these manual fixes).

The purpose of this intermediate/separate PR is that you/others can merge just this patch into your branches so you can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next.

@dbanks12 dbanks12 merged commit 7e44765 into master Apr 29, 2023
@dbanks12 dbanks12 deleted the db/clang-format-tidy-setup branch April 29, 2023 16:26
ludamad pushed a commit that referenced this pull request Jul 14, 2023
Co-authored-by: cheethas <addaboy@gmail.com>
codygunton pushed a commit that referenced this pull request Jan 23, 2024
Co-authored-by: cheethas <addaboy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants