Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundation should only use nested import #416

Closed
ludamad opened this issue May 1, 2023 · 1 comment
Closed

Foundation should only use nested import #416

ludamad opened this issue May 1, 2023 · 1 comment

Comments

@ludamad
Copy link
Collaborator

ludamad commented May 1, 2023

The catchall index of foundation comes up too often when automatically resolving imports. Also, it prevents future modularization (easily publishing to different packages, tree shaking optimizations in bundlers, etc). We should clean up the code to always import e.g.

import { EthAddress } from "@aztec/foundation/eth_address";
@github-project-automation github-project-automation bot moved this to Todo in A3 May 1, 2023
@Orloaft Orloaft mentioned this issue May 2, 2023
Merged
6 tasks
@ludamad ludamad mentioned this issue May 2, 2023
Closed
6 tasks
@Orloaft Orloaft mentioned this issue May 3, 2023
Merged
6 tasks
@ludamad
Copy link
Collaborator Author

ludamad commented Aug 1, 2023

Done by Orloaft in #449

@ludamad ludamad closed this as completed Aug 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update exports and imports of foundation (#433) AztecProtocol/aztec-packages
1 participant
@ludamad