Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PXE): Allow addNote to store nullified notes #4234

Closed
Tracked by #5070
nventuro opened this issue Jan 26, 2024 · 0 comments · Fixed by #6948
Closed
Tracked by #5070

feat(PXE): Allow addNote to store nullified notes #4234

nventuro opened this issue Jan 26, 2024 · 0 comments · Fixed by #6948
Assignees
@benesjan
Labels
C-aztec.js Component: aztec.js client library

Comments

@nventuro
Copy link
Contributor

aztec.js allows manual note storage via addNote() which performs inclusion and non-nullification tests. Given #4208, we may wish to relax these constraints to also allow storage of nullified notes, as otherwise the only possible way to keep track of them is by processing the block in which they were broadcast.
@nventuro nventuro added the C-aztec.js Component: aztec.js client library label Jan 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 26, 2024
This was referenced Mar 8, 2024
Open
Open
@LHerskind LHerskind changed the title Allow addNote to store nullified notes feat(PXE): Allow addNote to store nullified notes Mar 9, 2024
@benesjan benesjan assigned benesjan and unassigned nventuro Jun 6, 2024
@benesjan benesjan mentioned this issue Jun 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
C-aztec.js Component: aztec.js client library
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pxe.addNullifiedNote(...) AztecProtocol/aztec-packages
2 participants
@nventuro @benesjan