barretenberg top-level await fails doesn't match its target

[signorecello]

barretenberg top-level await makes NoirJS break in 0.23.0

Gonna expand a bit, this is what I think is happening:

• fix: Top level init bb.js, but better scoped imports to not incur cost too early #3629 introduces top-level await which should be ignored by CJS builds. So far, so good
• however, target is set as es2020
• when noir_js_backend_barretenberg updated to 0.23.0 it started using 0.21.0
• any program using 0.23.0 versions will fail regardless of their target, because the target is wrong in bb

How to reproduce

1. git clone https://github.com/noir-lang/noir-starter.git
2. cd noir-starter
3. git switch zpedro/0.23.0
4. cd vite-hardhat
5. yarn
6. cp .env.example .env
7. npx hardhat node
   In a different terminal, in noir-starter/vite-hardhat:
8. yarn install
9. NETWORK=localhost yarn dev

Error log in terminal

% NETWORK=localhost yarn dev

Nothing to compile
Nothing to compile
(node:20211) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm/transpile-only", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:20217) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm/transpile-only", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
Deployed at {
  chainId: 31337,
  verifier: '0x5fbdb2315678afecb367f032d93f642f64180aa3'
}

  VITE v5.0.6  ready in 246 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
✘ [ERROR] Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)

    node_modules/@aztec/bb.js/dest/browser/index.js:2:16426468:
      2 │ ...e.hasOwnProperty.call(A,I);var D=E(183),i=(D=await D).Zh,w=D.AL,h=D.i2,o=D.Fr,G=D.ld;export{i a...
        ╵                                                 ~~~~~

/.../noir-lang/noir-starter/vite-hardhat/node_modules/esbuild/lib/main.js:1650
  let error = new Error(text);
              ^

Error: Build failed with 1 error:
node_modules/@aztec/bb.js/dest/browser/index.js:2:16426468: ERROR: Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)
    at failureErrorWithLog (.../noir-lang/noir-starter/vite-hardhat/node_modules/esbuild/lib/main.js:1650:15)
    at /.../noir-lang/noir-starter/vite-hardhat/node_modules/esbuild/lib/main.js:1058:25
    at /.../noir-lang/noir-starter/vite-hardhat/node_modules/esbuild/lib/main.js:1526:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errors: [Getter/Setter],
  warnings: [Getter/Setter]
}

Node.js v20.11.

[signorecello]

here's a branch in noir-starter that can be useful to reproduce the error

[Savio-Sou]

@signorecello how do you go about reproducing the error?

I did:

1. git clone https://github.com/noir-lang/noir-starter.git
2. cd noir-starter
3. git switch zpedro/0.23.0
4. cd vite-hardhat
5. yarn
6. Copy-past .env.example into .env
7. npx hardhat node
8. NETWORK=localhost yarn build

which got me:

Is that the same error you're reporting?

[Savio-Sou]

Having updated to the latest noir-starter commit with caches cleared, NETWORK=localhost yarn build now build successfully.

Running yarn preview and accessing http://localhost:4173/ gives:

Is that the error expected?

[Savio-Sou]

Ok running yarn dev (instead of yarn preview) gets the error:

Updated Issue body with reproduction steps and error log.

[signorecello]

Yarn preview should work though 🥲 I’ll have a look

[ludamad]

Recreated with (slightly edited) instructions, looking into this

[ludamad]

Can you look at AztecProtocol/noir-starter#71 @signorecello ?

[Savio-Sou]

@signorecello did AztecProtocol/noir-starter#71 fix the issue? (And if yes, does that mean Noir 0.23.0 is not broken?)

[signorecello]

Correct 👍

[0x18a6]

I'm getting the exact same error using Noir 0.25.0

[Savio-Sou]

Hi @0x18a6, could you create a new Issue detailing how your error could be reproduced? Thanks!