Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contract-deploy] Implement "internal" as an app-level check in a macro #4449

Closed
Tracked by #4052
spalladino opened this issue Feb 6, 2024 · 1 comment
Closed
Tracked by #4052

[contract-deploy] Implement "internal" as an app-level check in a macro #4449

spalladino opened this issue Feb 6, 2024 · 1 comment

Comments

@spalladino
Copy link
Collaborator

spalladino commented Feb 6, 2024 •
edited
Loading

As we remove the internal property from functions in the protocol, we should reimplement this check at the application layer, by implementing it as a macro that inserts a msg.sender == this assertion at the start of the function call.
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 6, 2024
This was referenced Feb 6, 2024
Closed
Merged
@spalladino
Copy link
Collaborator Author

Closing as done

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spalladino