refactor: Get rid of Honk UltraComposer

[codygunton]

As the name says. Because of the previous PRs, this should be quite straightforward to review. Basic idea:

• Replace create_foo functions calls with Foo constructor calls.
• When using Composer in the type system, change to Flavor or Prover as the case may be.
• Update includes to resolve dependencies that were implicit in ultra_composer.hpp dependency.

Resolves AztecProtocol/barretenberg#892 as a side effect.

Follow up to: #4848

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 112 (+647%)
• note_trial_decrypting_time_in_ms (64): 136 (+110%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8619c084 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,228	238,928	469,148
l1_rollup_execution_gas	194,176	500,234	908,406
l2_block_processing_time_in_ms	1,192 (-3%)	4,484 (-2%)	8,887 (-3%)
note_successful_decrypting_time_in_ms	198 (-3%)	542 (-4%)	993 (-4%)
note_trial_decrypting_time_in_ms	⚠️ 112 (+647%)	63.2 (-32%)	⚠️ 136 (+110%)
l2_block_building_time_in_ms	15,912 (-2%)	62,942 (-2%)	126,047 (-2%)
l2_block_rollup_simulation_time_in_ms	12,098 (-2%)	47,875 (-2%)	95,973 (-2%)
l2_block_public_tx_process_time_in_ms	3,785 (-3%)	14,992 (-2%)	29,906 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,202 (-4%)	27,057 (-2%)
note_history_successful_decrypting_time_in_ms	1,233 (-1%)	2,333 (-4%)
note_history_trial_decrypting_time_in_ms	93.1 (-4%)	104 (-33%)
node_database_size_in_bytes	18,780,240	35,496,016
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	247 (-1%)	44,736	28,001
private-kernel-ordering	177 (-1%)	52,625	14,627
base-rollup	1,265 (-2%)	177,932	933
root-rollup	70.2 (-1%)	4,192	825
private-kernel-inner	313 (-1%)	73,715	28,001
public-kernel-app-logic	188 (-2%)	32,254	25,379
merge-rollup	5.68 (-2%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.71 (-2%)	10.1 (-8%)	13.6 (+8%)	16.1 (-4%)	21.9 (-14%)	35.2 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.563 (-2%)	0.561 (-7%)	0.579 (+9%)	0.496 (-3%)	0.459 (-13%)	0.439 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.2 (-2%)	71.3 (-3%)	229 (-3%)	434 (-3%)	860 (-2%)	1,710 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.463 (-2%)	0.440 (-3%)	0.418 (-2%)	0.407 (-3%)	0.410 (-1%)	0.409 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.5	107 (-2%)	340 (-2%)	645 (-3%)	1,304 (-1%)	2,595 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.485 (+1%)	0.481 (-1%)	0.457 (-2%)	0.444 (-3%)	0.453	0.450 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	60.1 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.525 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,617 (-1%)	1,351 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0311 (-8%)	461 (-2%)

[codygunton]

This was the only real complication this PR. I had to add some type aliases in the Plonk settings code to make this work.

[codygunton]

It's tempting to template by OuterVerifier and then extract the other types via the chain Verifier -> Prover -> Flavor -> Builder but it didn't seem necessary. The cost is that this code isn't generic in the flavor since we have hard-coded UltraFoo_s, but it doesn't need to be more generic.

[lucasxia01]

soon, from what? Plonk getting removed?

[codygunton]

Yeah

[codygunton]

Once we have a UH smart contract. Sean is working on this.

[codygunton]

Err, looks like someone is updating CI and currently no real jobs are running. Will need to kick off a legit run sometime next week before merging.

[ludamad]

Hmm you may need to comment with [ci rebuild] in commit. Not sure why this is happening, but the setup phase says BB is caching

[lucasxia01]

Looks good in general! Love the removal of autos, and good riddance to the composer

[lucasxia01]

in favor of getting rid of auto in most places 👍

[lucasxia01]

is there a point to the second argument here?

[codygunton]

removed