refactor: moving types consts to constants.nr

[benesjan]

I need to access INITIAL_L2_BLOCK_NUM in the new Inbox contract so I decided to move the constant to constants.nr so that the value gets generated in ConstantsGen.sol.

[benesjan]

• chore: integrating natspec-smells tool #4973
• feat: new Inbox #4880
• refactor: moving types consts to constants.nr #4919 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit cd1ca2e1 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,108	239,012	469,676
l1_rollup_execution_gas	194,056	500,318	908,934
l2_block_processing_time_in_ms	1,200	4,471 (-1%)	8,930
note_successful_decrypting_time_in_ms	206 (+2%)	547 (+2%)	1,003 (+1%)
note_trial_decrypting_time_in_ms	12.2 (+62%)	69.8 (+17%)	35.2 (-72%)
l2_block_building_time_in_ms	15,926	63,010 (-1%)	126,835 (-1%)
l2_block_rollup_simulation_time_in_ms	12,110	47,990	96,514 (-2%)
l2_block_public_tx_process_time_in_ms	3,787 (+1%)	14,952 (-3%)	30,143

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,238 (+1%)	26,963
note_history_successful_decrypting_time_in_ms	1,340 (+5%)	2,412 (-1%)
note_history_trial_decrypting_time_in_ms	99.0 (-1%)	136 (-20%)
node_database_size_in_bytes	18,796,624	35,250,256
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	248	44,736	28,001
private-kernel-ordering	178	52,625	14,627
base-rollup	1,285 (-1%)	177,932	933
root-rollup	71.0	4,192	825
private-kernel-inner	316 (+1%)	73,715	28,001
public-kernel-app-logic	191 (-1%)	32,254	25,379
merge-rollup	5.75	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.89	10.2 (-3%)	12.5 (-8%)	16.1 (-1%)	22.4 (+2%)	35.4	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.573	0.565 (-3%)	0.531 (-8%)	0.497	0.466 (+1%)	0.441	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.0	72.3	230	445	865	1,720
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.471	0.446	0.420	0.417	0.412	0.413
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.1	108	338	664	1,301 (-1%)	2,598
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.480	0.488	0.458	0.456	0.452	0.452
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.3	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.536	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,651 (+2%)	1,352

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0317 (-2%)	468

[sklppy88]

Looks good, but just curious, why is it importing sometimes from @aztec/circuits.js, and sometimes from @aztec/circuits.js/constants ?

Is there any reason why we're not unifying all the imports to just @aztec/circuits.js?

[benesjan]

@sklppy88 Ideally we would use @aztec/circuits.js/constants everywhere because that allows you to optimize build size which is important for web. I don't use that everywhere in the PR because in some places the specific constants "sub-package" was not in dependencies.