feat(avm): basic AVM-ACVM interoperability #5595

fcarreiro · 2024-04-05T17:22:15Z

Makes it possible to call external public calls to/from AVM/ACVM.

Modified traces.
Modified conversions to support most things except nested call tracking.
Added Header to context: This is not currently used in the AVM-simulator, but it's needed to have interoperability with the ACVM. In any case, we might use it for HEADERMEMBER.

I'll handle gas for nested calls in a separate PR.

fcarreiro · 2024-04-05T17:22:29Z

feat(avm): make authwit work with avm #5594
feat(avm): basic AVM-ACVM interoperability #5595 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

AztecBot · 2024-04-05T17:43:55Z

Benchmark results

Metrics with a significant change:

tx_sequencer_processing_time_ms (5): 1,751 (-17%)
tx_sequencer_processing_time_ms (8): 587 (-18%)
note_trial_decrypting_time_in_ms (8): 59.7 (+82%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f038b704 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,424	6,400
l1_rollup_execution_gas	585,745	585,757	585,733
l2_block_processing_time_in_ms	1,295 (-2%)	4,703	9,294
note_successful_decrypting_time_in_ms	259 (+12%)	567 (+1%)	1,030 (-3%)
note_trial_decrypting_time_in_ms	⚠️ 59.7 (+82%)	79.2 (+9%)	50.4 (-31%)
l2_block_building_time_in_ms	11,901 (+1%)	43,243 (+1%)	84,972 (+2%)
l2_block_rollup_simulation_time_in_ms	11,866 (+1%)	43,120 (+1%)	84,745 (+2%)
l2_block_public_tx_process_time_in_ms	6,161	24,192	48,909 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,957 (-2%)	26,245 (-4%)
note_history_successful_decrypting_time_in_ms	1,234 (-5%)	2,395 (-2%)
note_history_trial_decrypting_time_in_ms	64.7 (-6%)	102 (-3%)
node_database_size_in_bytes	18,657,360	35,086,416 (+1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	180 (+1%)	44,377	26,164
private-kernel-ordering	162 (+1%)	50,830	39,026
base-parity	3,874 (-2%)	128	311
root-parity	1,179 (+8%)	1,244	311
base-rollup	14,242	110,464	861
root-rollup	49.7	4,359	725
private-kernel-inner	218 (+1%)	71,744	26,164
public-kernel-app-logic	121 (+2%)	47,695	40,661
public-kernel-tail	165 (+1%)	53,372	7,125
merge-rollup	10.0 (-9%)	2,568	861
public-kernel-teardown	117 (-18%)	47,695	40,661
public-kernel-setup	116 (-1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	16.1 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.584	0.498 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.9 (-2%)	72.3 (-1%)	232	445 (-1%)	881 (+1%)	1,744 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471 (-1%)	0.445	0.423	0.416 (-1%)	0.418 (+1%)	0.417 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.3 (-2%)	107	338	658 (-1%)	1,312	2,603	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479 (-1%)	0.483	0.458	0.453 (-1%)	0.455	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.0 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.533 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,703 (+1%)	1,077	5,456 (+1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	578 (+1%)	400	1,075	496 (-5%)	⚠️ 1,751 (-17%)	⚠️ 587 (-18%)

dbanks12 · 2024-04-08T16:58:32Z

yarn-project/end-to-end/src/e2e_avm_simulator.test.ts

+      // Cannot work because ACVM does not support pending nullifiers.
+      // it('AVM->ACVM nullifiers work (pending)', async () => {
+      //   await avmContract.methods.avm_to_acvm_nullifier().send().wait();
+      // });
+
+      it('AVM sees settled nullifiers by ACVM', async () => {
+        const nullifier = new Fr(123456);
+        await avmContract.methods.new_nullifier(nullifier).send().wait();
+        await avmContract.methods.assert_unsiloed_nullifier_acvm(nullifier).send().wait();
+      });
+
+      it('AVM nested call to ACVM sees settled nullifiers', async () => {
+        const nullifier = new Fr(123456);
+        await avmContract.methods.new_nullifier(nullifier).send().wait();
+        await avmContract.methods
+          .avm_to_acvm_call(FunctionSelector.fromSignature('assert_unsiloed_nullifier_acvm(Field)'), nullifier)
+          .send()
+          .wait();
+      });
+    });
  });


Ugh, I wish we didn't have to go down this rabbit hole of accumulating/passing nullifiers between ACVM and AVM

yarn-project/simulator/src/avm/avm_simulator.test.ts

yarn-project/simulator/src/avm/opcodes/external_calls.test.ts

yarn-project/simulator/src/avm/opcodes/external_calls.ts

dbanks12 · 2024-04-08T18:24:51Z

yarn-project/simulator/src/public/executor.ts

I like the changes here!

dbanks12 · 2024-04-08T18:27:08Z

yarn-project/simulator/src/public/transitional_adaptors.ts

Nicely done! It's unfortunate that we have to do all of this.... But I can't think of a better way. It will get even uglier when we properly handle nested calls to different contracts and pass their side-effects to the kernel.

dbanks12

LGTM!

yarn-project/circuits.js/src/contract/artifact_hash.test.ts

dbanks12 · 2024-04-09T15:52:25Z

yarn-project/end-to-end/src/e2e_avm_simulator.test.ts

+
+      // Cannot work because ACVM does not support pending nullifiers.
+      // it('AVM->ACVM nullifiers work (pending)', async () => {
+      //   await avmContract.methods.avm_to_acvm_nullifier().send().wait();
+      // });
+


Should this EVER work? If not, should we remove the commented code? If it SHOULD work someday, maybe we link a ticket?

I think it will never work. Removed.

dbanks12 · 2024-04-09T15:53:28Z

yarn-project/simulator/src/avm/avm_execution_environment.ts

    public readonly contractCallDepth: Fr,
-
+    public readonly header: Header,


I think we might eventually want opcodes to directly get certain entries from this header (different from HEADERMEMBER which gets historic info)

Yes, we can do all of it from DB at that point. This was the easy way out for now :)
BTW, when I discussed with Lasse, he thought that HEADERMEMBER only made sense w/the latest header, because all the rest you can do in private.

dbanks12 · 2024-04-09T15:54:02Z

yarn-project/simulator/src/avm/avm_simulator.test.ts

@@ -502,7 +547,7 @@ describe('AVM simulator: transpiled Noir contracts', () => {
      const context = initContext({ env: initExecutionEnvironment({ calldata }) });
      jest
        .spyOn(context.persistableState.hostStorage.contractsDb, 'getBytecode')
-        .mockReturnValueOnce(Promise.resolve(addBytecode));
+        .mockReturnValue(Promise.resolve(addBytecode));


Is mockReturnValue preferred over mockReturnValueOnce?

No! But since I'm now getting the bytecode first to decide if it's AVM or ACVM I needed to change it.

dbanks12 · 2024-04-09T15:54:46Z

yarn-project/simulator/src/avm/avm_simulator.test.ts

      expect(results.reverted).toBe(true); // The outer call should revert.
+      // TODO(fcarreiro): revertReason lost in translation between results.
+      // expect(results.revertReason).toEqual(/StaticCallStorageAlterError/);
    });


Why is the revertReason lost? Also is there a ticket or more info on how/when this will be solved?

I think it's because the way nested calls in PublicExecution* are handled. Nested executions in current public are not expected to revert and carry on, they would throw and everything dies. This should certainly work once we remove the usage of the ACVM, but I might need to get it working somehow before that.

dbanks12 · 2024-04-09T15:56:08Z

yarn-project/simulator/src/avm/journal/trace.ts

-
-  /**
-   * We want to keep track of all performed reads in the journal
-   * This information is hinted to the avm circuit
-
-   * @param contractAddress -
-   * @param key -
-   * @param value -
-   */
-  journalUpdate(map: Map<bigint, Map<bigint, Fr[]>>, contractAddress: Fr, key: Fr, value: Fr): void {
-    let contractMap = map.get(contractAddress.toBigInt());
-    if (!contractMap) {
-      contractMap = new Map<bigint, Array<Fr>>();
-      map.set(contractAddress.toBigInt(), contractMap);
-    }
-
-    let accessArray = contractMap.get(key.toBigInt());
-    if (!accessArray) {
-      accessArray = new Array<Fr>();
-      contractMap.set(key.toBigInt(), accessArray);
-    }
-    accessArray.push(value);
-  }
-
-  // Create an instance of journalUpdate that appends to the read array
-  private journalRead = this.journalUpdate.bind(this, this.publicStorageReads);
-  // Create an instance of journalUpdate that appends to the writes array
-  private journalWrite = this.journalUpdate.bind(this, this.publicStorageWrites);
-}
-
-/**
- * Merges two contract journalling maps together
- * For read maps, we just append the childMap arrays into the host map arrays, as the order is important
- *
- * @param hostMap - The map to be merged into
- * @param childMap - The map to be merged from
- */
-function mergeContractJournalMaps(hostMap: Map<bigint, Map<bigint, Fr[]>>, childMap: Map<bigint, Map<bigint, Fr[]>>) {
-  for (const [key, value] of childMap) {
-    const map1Value = hostMap.get(key);
-    if (!map1Value) {
-      hostMap.set(key, value);
-    } else {
-      mergeStorageJournalMaps(map1Value, value);
-    }
-  }
-}
-
-/**
- * Merge two storage journalling maps together (for a particular contract).
- *
- * @param hostMap - The map to be merge into
- * @param childMap - The map to be merged from
- */
-function mergeStorageJournalMaps(hostMap: Map<bigint, Fr[]>, childMap: Map<bigint, Fr[]>) {
-  for (const [key, value] of childMap) {
-    const readArr = hostMap.get(key);
-    if (!readArr) {
-      hostMap.set(key, value);
-    } else {
-      hostMap.set(key, readArr?.concat(...value));
-    }
-  }
 }


Nice that you could delete all this! I've been hoping to for a while now!

fcarreiro · 2024-04-09T18:09:58Z

Merge activity

Apr 9, 2:09 PM EDT: @fcarreiro merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.34.0</summary> ## [0.34.0](aztec-package-v0.33.0...aztec-package-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) </details> <details><summary>barretenberg.js: 0.34.0</summary> ## [0.34.0](barretenberg.js-v0.33.0...barretenberg.js-v0.34.0) (2024-04-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.34.0</summary> ## [0.34.0](aztec-cli-v0.33.0...aztec-cli-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) </details> <details><summary>aztec-packages: 0.34.0</summary> ## [0.34.0](aztec-packages-v0.33.0...aztec-packages-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](#5617)) ### Features * **acvm_js:** Execute program (noir-lang/noir#4694) ([ff28080](ff28080)) * Add `remove_enable_side_effects` SSA pass (noir-lang/noir#4224) ([ff28080](ff28080)) * Allow slices to brillig entry points (noir-lang/noir#4713) ([ff28080](ff28080)) * **avm:** Basic AVM-ACVM interoperability ([#5595](#5595)) ([d872445](d872445)) * **avm:** Make authwit work with avm ([#5594](#5594)) ([b02d1e1](b02d1e1)) * **docs:** Documenting noir codegen (noir-lang/noir#4454) ([ff28080](ff28080)) * Generalize protogalaxy to multiple instances ([#5510](#5510)) ([f038b70](f038b70)) * Improve nargo check cli with --override flag and feedback for existing files (noir-lang/noir#4575) ([ff28080](ff28080)) * Improve optimisations on range constraints (noir-lang/noir#4690) ([ff28080](ff28080)) * Improve SSA type-awareness in EQ and MUL instructions (noir-lang/noir#4691) ([ff28080](ff28080)) * **nargo:** Multiple circuits info for binary programs (noir-lang/noir#4719) ([ff28080](ff28080)) * Stdlib databus ([#5598](#5598)) ([633a711](633a711)) ### Bug Fixes * **acvm:** Mark outputs of Opcode::Call solvable (noir-lang/noir#4708) ([ff28080](ff28080)) * Do not retry RPC requests on 4xx errors ([#5634](#5634)) ([5af2b95](5af2b95)) * Field comparisons (noir-lang/noir#4704) ([ff28080](ff28080)) * Last use analysis & make it an SSA pass (noir-lang/noir#4686) ([ff28080](ff28080)) * **ssa:** Do not use get_value_max_num_bits when we want pure type information (noir-lang/noir#4700) ([ff28080](ff28080)) * Unknown slice lengths coming from as_slice (noir-lang/noir#4725) ([ff28080](ff28080)) * Use empty artifact in test ([#5640](#5640)) ([1d18a5e](1d18a5e)) ### Miscellaneous * Check for references to private functions during path resolution (noir-lang/noir#4622) ([ff28080](ff28080)) * **ci:** Fix cutting new versions of the docs (noir-lang/noir#4737) ([ff28080](ff28080)) * **ci:** Replace `yarn build:js:only` script (noir-lang/noir#4735) ([ff28080](ff28080)) * **ci:** Stop updating version list before cutting new docs version (noir-lang/noir#4726) ([ff28080](ff28080)) * Disable earthly cloud ([#5639](#5639)) ([47e9c25](47e9c25)) * Fix clippy errors (noir-lang/noir#4684) ([ff28080](ff28080)) * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) * Remove `FunctionInput::dummy` (noir-lang/noir#4723) ([ff28080](ff28080)) * Remove conditional compilation around `acvm_js` package (noir-lang/noir#4702) ([ff28080](ff28080)) * Remove docker CI flow (noir-lang/noir#4724) ([ff28080](ff28080)) * Remove fixed-length keccak256 ([#5617](#5617)) ([40480b3](40480b3)) * Remove last traces of nix (noir-lang/noir#4679) ([ff28080](ff28080)) * Remove unused env vars from `Cross.toml` (noir-lang/noir#4717) ([ff28080](ff28080)) * Replace relative paths to noir-protocol-circuits ([bc214c5](bc214c5)) * Simplify how `acvm_backend.wasm` is embedded (noir-lang/noir#4703) ([ff28080](ff28080)) * Simplify how blns is loaded into tests (noir-lang/noir#4705) ([ff28080](ff28080)) * Update condition for clearing warning comment on release PRs (noir-lang/noir#4739) ([ff28080](ff28080)) * Update from vulnerable version of h2 (noir-lang/noir#4714) ([ff28080](ff28080)) * Update JS publish workflow to upload build artifacts correctly. (noir-lang/noir#4734) ([ff28080](ff28080)) * Use is_entry_point helper on RuntimeType (noir-lang/noir#4678) ([ff28080](ff28080)) </details> <details><summary>barretenberg: 0.34.0</summary> ## [0.34.0](barretenberg-v0.33.0...barretenberg-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](#5617)) ### Features * Generalize protogalaxy to multiple instances ([#5510](#5510)) ([f038b70](f038b70)) * Stdlib databus ([#5598](#5598)) ([633a711](633a711)) ### Miscellaneous * Remove fixed-length keccak256 ([#5617](#5617)) ([40480b3](40480b3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-package-v0.33.0...aztec-package-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) </details> <details><summary>barretenberg.js: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@barretenberg.js-v0.33.0...barretenberg.js-v0.34.0) (2024-04-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-cli-v0.33.0...aztec-cli-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) </details> <details><summary>aztec-packages: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-packages-v0.33.0...aztec-packages-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ### Features * **acvm_js:** Execute program (noir-lang/noir#4694) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Add `remove_enable_side_effects` SSA pass (noir-lang/noir#4224) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Allow slices to brillig entry points (noir-lang/noir#4713) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **avm:** Basic AVM-ACVM interoperability ([#5595](AztecProtocol/aztec-packages#5595)) ([d872445](AztecProtocol/aztec-packages@d872445)) * **avm:** Make authwit work with avm ([#5594](AztecProtocol/aztec-packages#5594)) ([b02d1e1](AztecProtocol/aztec-packages@b02d1e1)) * **docs:** Documenting noir codegen (noir-lang/noir#4454) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Generalize protogalaxy to multiple instances ([#5510](AztecProtocol/aztec-packages#5510)) ([f038b70](AztecProtocol/aztec-packages@f038b70)) * Improve nargo check cli with --override flag and feedback for existing files (noir-lang/noir#4575) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Improve optimisations on range constraints (noir-lang/noir#4690) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Improve SSA type-awareness in EQ and MUL instructions (noir-lang/noir#4691) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **nargo:** Multiple circuits info for binary programs (noir-lang/noir#4719) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Stdlib databus ([#5598](AztecProtocol/aztec-packages#5598)) ([633a711](AztecProtocol/aztec-packages@633a711)) ### Bug Fixes * **acvm:** Mark outputs of Opcode::Call solvable (noir-lang/noir#4708) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Do not retry RPC requests on 4xx errors ([#5634](AztecProtocol/aztec-packages#5634)) ([5af2b95](AztecProtocol/aztec-packages@5af2b95)) * Field comparisons (noir-lang/noir#4704) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Last use analysis & make it an SSA pass (noir-lang/noir#4686) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ssa:** Do not use get_value_max_num_bits when we want pure type information (noir-lang/noir#4700) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Unknown slice lengths coming from as_slice (noir-lang/noir#4725) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Use empty artifact in test ([#5640](AztecProtocol/aztec-packages#5640)) ([1d18a5e](AztecProtocol/aztec-packages@1d18a5e)) ### Miscellaneous * Check for references to private functions during path resolution (noir-lang/noir#4622) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Fix cutting new versions of the docs (noir-lang/noir#4737) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Replace `yarn build:js:only` script (noir-lang/noir#4735) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Stop updating version list before cutting new docs version (noir-lang/noir#4726) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Disable earthly cloud ([#5639](AztecProtocol/aztec-packages#5639)) ([47e9c25](AztecProtocol/aztec-packages@47e9c25)) * Fix clippy errors (noir-lang/noir#4684) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) * Remove `FunctionInput::dummy` (noir-lang/noir#4723) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove conditional compilation around `acvm_js` package (noir-lang/noir#4702) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove docker CI flow (noir-lang/noir#4724) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ([40480b3](AztecProtocol/aztec-packages@40480b3)) * Remove last traces of nix (noir-lang/noir#4679) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove unused env vars from `Cross.toml` (noir-lang/noir#4717) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Replace relative paths to noir-protocol-circuits ([bc214c5](AztecProtocol/aztec-packages@bc214c5)) * Simplify how `acvm_backend.wasm` is embedded (noir-lang/noir#4703) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Simplify how blns is loaded into tests (noir-lang/noir#4705) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update condition for clearing warning comment on release PRs (noir-lang/noir#4739) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update from vulnerable version of h2 (noir-lang/noir#4714) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update JS publish workflow to upload build artifacts correctly. (noir-lang/noir#4734) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Use is_entry_point helper on RuntimeType (noir-lang/noir#4678) ([ff28080](AztecProtocol/aztec-packages@ff28080)) </details> <details><summary>barretenberg: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@barretenberg-v0.33.0...barretenberg-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ### Features * Generalize protogalaxy to multiple instances ([#5510](AztecProtocol/aztec-packages#5510)) ([f038b70](AztecProtocol/aztec-packages@f038b70)) * Stdlib databus ([#5598](AztecProtocol/aztec-packages#5598)) ([633a711](AztecProtocol/aztec-packages@633a711)) ### Miscellaneous * Remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ([40480b3](AztecProtocol/aztec-packages@40480b3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fcarreiro changed the title ~~feat(avm): add Header to AvmExecutionEnvironment~~ feat(avm): basic AVM-ACVM interoperability Apr 5, 2024

fcarreiro mentioned this pull request Apr 5, 2024

feat(avm): make authwit work with avm #5594

Merged

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch 4 times, most recently from 2e89a28 to 6ccd909 Compare April 8, 2024 18:10

dbanks12 reviewed Apr 8, 2024

View reviewed changes

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 6ccd909 to dd50e6f Compare April 9, 2024 09:23

fcarreiro marked this pull request as ready for review April 9, 2024 09:23

fcarreiro requested a review from Maddiaa0 as a code owner April 9, 2024 09:23

fcarreiro requested a review from dbanks12 April 9, 2024 09:24

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from dd50e6f to 258ed4e Compare April 9, 2024 09:29

fcarreiro removed the request for review from Maddiaa0 April 9, 2024 09:37

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch 3 times, most recently from fb1def3 to 8416597 Compare April 9, 2024 11:02

dbanks12 approved these changes Apr 9, 2024

View reviewed changes

fcarreiro added 2 commits April 9, 2024 17:19

feat(avm): add Header to AvmExecutionEnvironment

a3d88d7

wip

d11d240

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 8416597 to e733a83 Compare April 9, 2024 17:29

done

8fc5b98

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from e733a83 to 8fc5b98 Compare April 9, 2024 17:32

fcarreiro merged commit d872445 into master Apr 9, 2024
108 of 111 checks passed

fcarreiro deleted the fc/avm-simulator-interoperability-2 branch April 9, 2024 18:09

AztecBot mentioned this pull request Apr 9, 2024

chore(master): Release 0.34.0 #5629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): basic AVM-ACVM interoperability #5595

feat(avm): basic AVM-ACVM interoperability #5595

fcarreiro commented Apr 5, 2024 •

edited

Loading

fcarreiro commented Apr 5, 2024 •

edited

Loading

AztecBot commented Apr 5, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

dbanks12 Apr 8, 2024

dbanks12 Apr 8, 2024

dbanks12 Apr 8, 2024

dbanks12 left a comment

dbanks12 Apr 9, 2024

fcarreiro Apr 9, 2024

dbanks12 Apr 9, 2024

fcarreiro Apr 9, 2024

dbanks12 Apr 9, 2024

fcarreiro Apr 9, 2024

dbanks12 Apr 9, 2024

fcarreiro Apr 9, 2024

dbanks12 Apr 9, 2024

fcarreiro commented Apr 9, 2024

		public readonly contractCallDepth: Fr,

		public readonly header: Header,

feat(avm): basic AVM-ACVM interoperability #5595

feat(avm): basic AVM-ACVM interoperability #5595

Conversation

fcarreiro commented Apr 5, 2024 • edited Loading

fcarreiro commented Apr 5, 2024 • edited Loading

AztecBot commented Apr 5, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbanks12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fcarreiro commented Apr 9, 2024

Merge activity

fcarreiro commented Apr 5, 2024 •

edited

Loading

fcarreiro commented Apr 5, 2024 •

edited

Loading

AztecBot commented Apr 5, 2024 •

edited

Loading