Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use is_default_array insead of checking array_length = 0 in noir-protocol-circuits #5618

Open
sklppy88 opened this issue Apr 8, 2024 · 0 comments

Comments

@sklppy88
Copy link
Contributor

sklppy88 commented Apr 8, 2024

Search TODO: #5618 in the codebase

example:

        assert(
            is_default_array(public_inputs.new_note_hashes), "new_note_hashes must be a default array (zeroed) for static calls"
        );
        assert(
            is_default_array(public_inputs.new_nullifiers), "new_nullifiers must be a default array (zeroed) for static calls"
        );

        let new_l2_to_l1_msgs_length = array_length(public_inputs.new_l2_to_l1_msgs);
        assert(new_l2_to_l1_msgs_length == 0, "new_l2_to_l1_msgs must be empty (length 0) for static calls");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant