Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simulator to handle call stacks across multiple ACIR functions #5813

Open
vezenovm opened this issue Apr 17, 2024 · 3 comments
Open
Labels
C-pxe Component: PXE (Private eXecution Envrionment)

Comments

@vezenovm
Copy link
Contributor

We altered the way call stack are handled in nargo in this PR noir-lang/noir#4711. This was a necessary update in order to have accurate user-facing errors after enabling non-inlined ACIR (noir-lang/noir#4428). Right now using the #[fold] attribute is unsupported for Aztec but even if this is not supported for aztec contracts, we might want to take advantage of other non-inlined ACIR functionality for optimizations. If we plan to take advantage of non-inlined ACIR in aztec contracts we need to update how debug info is handled in the simulator. We should be able to update the simulator in a similar way to how it was handled in nargo in the Noir PR linked above.

@vezenovm vezenovm added the C-pxe Component: PXE (Private eXecution Envrionment) label Apr 17, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 17, 2024
@sirasistant
Copy link
Collaborator

sirasistant commented Apr 18, 2024

I think this also needs to update the acvm_js with a similar treatment as nargo received in noir-lang/noir#4711 because the simulator expects to receive built call stacks, that I think right now will be incomplete (?)

@vezenovm
Copy link
Contributor Author

Yeah this would most likely require some updating to acvm js as well

@vezenovm
Copy link
Contributor Author

vezenovm commented May 3, 2024

This issue (#6182) would most likely need to come first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-pxe Component: PXE (Private eXecution Envrionment)
Projects
Status: Todo
Development

No branches or pull requests

2 participants