Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the inbox force insertion with real messages #613

Closed
LHerskind opened this issue May 17, 2023 · 0 comments · Fixed by #643
Closed

Replace the inbox force insertion with real messages #613

LHerskind opened this issue May 17, 2023 · 0 comments · Fixed by #643
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

Solidity and end to end tests are currently using randomized blocks which means that it require specific entryKeys to be inserted into the inbox. This is currently done by abusing foundry to overwrite storage slots directly. Remove the force insertion and insert actual messages into the inbox instead.
@LHerskind LHerskind added this to A3 May 17, 2023
@LHerskind LHerskind converted this from a draft issue May 17, 2023
@LHerskind LHerskind mentioned this issue May 17, 2023
Merged
6 tasks
@LHerskind LHerskind self-assigned this May 22, 2023
@LHerskind LHerskind mentioned this issue May 22, 2023
Merged
6 tasks
@LHerskind LHerskind moved this from Todo to In Progress in A3 May 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 May 23, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace force insert in TS AztecProtocol/aztec-packages
1 participant
@LHerskind