Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #701 - separate interface for pending l1 -> l2 message store #702

Merged
merged 2 commits into from
May 26, 2023
Merged

fix #701 - separate interface for pending l1 -> l2 message store #702

merged 2 commits into from
May 26, 2023

Conversation

rahul-kothari
Copy link
Contributor

Description

Fixes #701

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@rahul-kothari rahul-kothari requested a review from Maddiaa0 May 26, 2023 13:29
Maddiaa0
Maddiaa0 approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice

@Maddiaa0 Maddiaa0 enabled auto-merge (squash) May 26, 2023 15:24
@Maddiaa0 Maddiaa0 merged commit fc2d4c8 into master May 26, 2023
@Maddiaa0 Maddiaa0 deleted the rk/701-pendingstore branch May 26, 2023 15:31
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only Pending l1->l2 messages store should have getMessages(take: number) method implemented.
2 participants
@rahul-kothari @Maddiaa0