Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to wasi-sdk 20 compatible barretenberg #704

Merged
merged 55 commits into from
Jun 9, 2023
Merged

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented May 27, 2023

Description

  • Attempting to get rid of primitives.wasm as it's just one more thing to maintain. Currently just copies barretenberg.wasm to where primitivies.wasm was.
  • Bump up wasi to 20 from 12.
  • Stop using totally broken CRS stuff in favour of global crs.
  • Initialize wasi 20 c runtime properly after loading wasm.

TODO:

  • Call srs_init to init global srs!

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
Copy link
Collaborator

ludamad commented Jun 7, 2023

just periodically peeking
"Step 10/12 : COPY --from=builder /usr/src/circuits/cpp/build-wasm/bin/aztec3-circuits.wasm /usr/src/circuits/cpp/build-wasm/bin/aztec3-circuits.wasm
---> 51e0f6bc0714
Step 11/12 : COPY --from=builder /usr/src/circuits/cpp/barretenberg/cpp/build-wasm/bin/barretenberg.wasm /usr/src/circuits/cpp/barretenberg/cpp/build-wasm/bin/primitives.wasm
COPY failed: stat usr/src/circuits/cpp/barretenberg/cpp/build-wasm/bin/barretenberg.wasm: file does not exist
Terminating spot instance.."
Looks like we could just copy circuits wasm until we get rid of this entirely

@codygunton
Copy link
Contributor

Note: c2ad78a was giving a bad alloc error on the private kernel circuit deposit test when run locally, but the error didn't show up in CI 😕

@ludamad
Copy link
Collaborator

ludamad commented Jun 9, 2023

Merged here so I can update with master

@ludamad ludamad changed the title Integrating barretenberg low mem/threading/bb.js changes. feat: bump to wasi-sdk 20 compatible barretenberg Jun 9, 2023
@ludamad ludamad merged commit 2d5a6b6 into master Jun 9, 2023
@ludamad ludamad deleted the cl/bb_bump branch June 9, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants