Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Event_Logs): Update unencrypted emit in public #7162

Closed
Tracked by #2783
LHerskind opened this issue Jun 24, 2024 · 2 comments · Fixed by #7232
Closed
Tracked by #2783

feat(Event_Logs): Update unencrypted emit in public #7162

LHerskind opened this issue Jun 24, 2024 · 2 comments · Fixed by #7232
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 24, 2024

In PublicContext the emit_unencrypted_log_with_selector and emit_unencrypted_log. I'm not really sure "why" it actually have event id as part of what it is emitting. In my mind it would be useful to just have emit_raw_log in there, and then use a similar .emit function on events etc to deal with how it is actually constructing the message that is broadcast. Not clear to me why we are enshrining the event id in there.

Likely useful to hear what @fcarreiro says on this 👀.

@fcarreiro
Copy link
Contributor

I think from our PoV we are (more than) happy to just remove the event selector from the opcode (and context) if it's not needed as something enshrined. It's currently implemented that way because it was in the (vm) spec. @dbanks12 wdyt?

@sklppy88
Copy link
Contributor

sklppy88 commented Jun 28, 2024

Closed with #7232 and #7192. Have created #7198 for cleanup and will tackle next.

Thanks @fcarreiro !

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants