Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume larger token notes first #7731

Open
nventuro opened this issue Aug 1, 2024 · 0 comments
Open

Consume larger token notes first #7731

nventuro opened this issue Aug 1, 2024 · 0 comments

Comments

@nventuro
Copy link
Contributor

nventuro commented Aug 1, 2024

#7730 doesn't ask the oracle for the largest notes, and hence may require more iterations than strictly needed. It could be argued that we may not wish to return the notes in descending order as that may lead to excessive fragmentation and creation of change notes, but I'm not entirely sure how we may avoid it other than by having PXE be quite smart when it comes to note retrieval, or by passing extra hints to it.

If we do this, we should add a test to check that we're consuming the expected number of notes, as well as check that the extra constraints (for sorted notes) don't result in a large gate count increase (since we're not actually interested in those constraints in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant