Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: what if app circuit outputs different #read-requests vs what the RPC client gets from the simulator? #779

Closed
dbanks12 opened this issue Jun 8, 2023 · 1 comment
Assignees
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Contributor

dbanks12 commented Jun 8, 2023

Does it matter if i use readRequests.length or readRequestsMembershipWitnesses.length in kernel prover?
Do I need to assert that they are the same?
Do I need separate length constants for app circuit and kernel? (smaller length for app circuit outputs, larger length for kernel which accumulates read requests across iterations)

In private_execution.ts's getNotes2, if preimages length is > rrcIndices length, we are either relying on the app circuit to remove fake preimages, or on the kernel to handle the length diff.

@dbanks12 dbanks12 added C-protocol-circuits Component: Protocol circuits (kernel & rollup) spike labels Jun 8, 2023
@dbanks12 dbanks12 self-assigned this Jun 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 8, 2023
@dbanks12 dbanks12 moved this from Todo to In Progress in A3 Jun 29, 2023
@dbanks12 dbanks12 moved this from In Progress to Todo in A3 Jul 12, 2023
@dbanks12
Copy link
Contributor Author

This is still a conversation we should dig into.... It has changed a bit now, but how can we be certain that app circuit read requests align perfectly with readRequstPartialWitnesses constructed in ClientTxExecutionContext?

@dbanks12 dbanks12 closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
Archived in project
Development

No branches or pull requests

1 participant