Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: get_2 in set.nr only pushes one read_request even when reading two notes #780

Closed
dbanks12 opened this issue Jun 8, 2023 · 2 comments
Assignees
Labels
S-needs-discussion Status: Still needs more discussion before work can start. T-bug Type: Bug. Something is broken.

Comments

@dbanks12
Copy link
Contributor

dbanks12 commented Jun 8, 2023

This needs to conditionally push a read request when it is "real", but the conditionals aren't working in noir right now.

https://github.com/AztecProtocol/aztec-packages/pull/619/files#diff-98aba17498c42747e6eea4b9f4c24010109183be073839e90cceea843a5a3a81R49-R68

        let note0_hash = notes.0.compute_note_hash();
        //let note1_hash = notes.1.compute_note_hash();

        //if notes.0.is_real  {
        //    context = context.push_read_request(note0_hash);
        //}
        //if notes.1.is_real {
        //    context = context.push_read_request(note1_hash);
        //}
        // needed for some reason to avoid compile error?
        //constrain updated_context.args.get(0) != 0x0bad;
        //(updated_context, notes)

        // TODO/FIXME(dbanks12): really should be using the above
        // conditionals to only push 'real' notes to context, but
        // the conditionals do not work right yet.
        // need to include 0-2 notes based on is_real!!!!
        // https://github.com/AztecProtocol/aztec-packages/issues/780
        (
            context
                .push_read_request(note0_hash),
                //.push_read_request(note1_hash),
            notes
        )
@dbanks12 dbanks12 added T-bug Type: Bug. Something is broken. S-needs-discussion Status: Still needs more discussion before work can start. labels Jun 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 8, 2023
@dbanks12 dbanks12 self-assigned this Jun 8, 2023
@dbanks12
Copy link
Contributor Author

dbanks12 commented Jun 8, 2023

@sirasistant or @vezenovm is there a Noir ticket(s) I can follow that relates to these limitations in conditionals?

@dbanks12
Copy link
Contributor Author

No longer an issue.

@dbanks12 dbanks12 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 12, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-discussion Status: Still needs more discussion before work can start. T-bug Type: Bug. Something is broken.
Projects
None yet
Development

No branches or pull requests

1 participant