We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The select function has the following signature:
select
pub fn select<T>( &mut self, property_selector: PropertySelector, value: T, comparator: Option<u8>)
If the option is none, it defaults to EQ. This makes for cryptic code, e.g.:
none
EQ
options.select(NFTNote::properties().token_id, token_id, Option::none()).set_limit(1);
I think we should remove this option and make the comparator mandatory, so the above would then become:
options.select(NFTNote::properties().token_id, token_id, EQ).set_limit(1);
which is much more reasonable. We could even switch the order of the params, like we did in #8384, so that it's lhs, op, rhs.
lhs, op, rhs
The text was updated successfully, but these errors were encountered:
Having lhs, op, rhs would be nice 👍
Sorry, something went wrong.
nventuro
Successfully merging a pull request may close this issue.
The
select
function has the following signature:If the option is
none
, it defaults toEQ
. This makes for cryptic code, e.g.:I think we should remove this option and make the comparator mandatory, so the above would then become:
which is much more reasonable. We could even switch the order of the params, like we did in #8384, so that it's
lhs, op, rhs
.The text was updated successfully, but these errors were encountered: