chore: fix a load of warnings in aztec-nr

[TomAFrench]

aztec-nr isn't properly specifying the visibility of its re-exports so there's a ton of warnings. This PR addresses some of them along with some unused imports.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 703 (-50%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 41.9 (-70%)
• avm_simulation_time_ms (Token:mint_public): 45.3 (-83%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 254 (+393%)
• avm_simulation_time_ms (Token:transfer_public): 13.7 (-52%)
• l2_block_processing_time_in_ms (4): 256 (-18%)
• l2_block_processing_time_in_ms (16): 814 (-32%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,769 (+1%)	1,554	708	745 (-2%)	776 (+1%)
proof_construction_time_sha256_30_ms	11,539 (+1%)	3,076 (+1%)	1,372 (+1%)	1,415 (+1%)	1,465
proof_construction_time_sha256_100_ms	44,299 (+1%)	11,847 (+1%)	5,468 (-7%)	5,846 (-4%)	5,437 (+2%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	35.0 (+3%)	58.0 (+2%)	88.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,534	420 (+1%)	201	228	267
proof_construction_time_poseidon_hash_100_ms	5,668 (+1%)	1,521 (+1%)	673	728 (-4%)	750

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,792	97,646	186,884
l1_rollup_execution_gas	819,478	1,555,740	3,346,413
l2_block_processing_time_in_ms	⚠️ 256 (-18%)	450 (-1%)	⚠️ 814 (-32%)
l2_block_building_time_in_ms	9,306	18,349 (-3%)	36,467 (-1%)
l2_block_rollup_simulation_time_in_ms	9,306	18,349 (-3%)	36,466 (-1%)
l2_block_public_tx_process_time_in_ms	7,908	16,920 (-3%)	35,026 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,125 (+1%)	4,055 (-2%)
node_database_size_in_bytes	14,237,936	18,260,208
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	70.1 (-7%)	395 (-2%)	20,975	44,933	N/A
private-kernel-inner	139 (-1%)	715 (-2%)	71,787	45,067	N/A
private-kernel-reset-tiny	334	721 (-6%)	64,273	44,922	N/A
private-kernel-tail	152 (-2%)	135 (-5%)	50,551	57,178	N/A
base-parity	5.59	N/A	160	96.0	N/A
root-parity	35.0	N/A	73,964	96.0	N/A
base-rollup	2,107 (-3%)	N/A	189,128	664	N/A
block-root-rollup	41.3 (-1%)	N/A	58,217	2,448	N/A
public-kernel-setup	86.4 (-2%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	99.5	N/A	114,251	79,670	N/A
public-kernel-tail	582 (-3%)	N/A	487,098	16,414	N/A
private-kernel-reset-small	304 (-3%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 703 (-50%)	618 (-5%)	448,120	1,825	N/A
public-kernel-teardown	85.3 (-2%)	N/A	114,697	79,670	N/A
merge-rollup	20.0	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	99,658 (-2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	348 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.6 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	424 (-2%)
FeeJuice:deploy	1,376	11,731	393 (-1%)
SchnorrAccount:constructor	1,312	11,731	61.4 (-1%)
SchnorrAccount:entrypoint	2,336	11,731	370
FeeJuice:claim	1,344	11,731	35.9 (-6%)
Token:privately_mint_private_note	1,280	11,731	69.9 (-6%)
FPC:fee_entrypoint_public	1,344	11,731	25.9 (-3%)
Token:transfer	1,312	11,731	214 (+1%)
Benchmarking:create_note	1,344	11,731	73.3 (-2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.2
Token:unshield	1,376	11,731	484
FPC:fee_entrypoint_private	1,376	11,731	640

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 41.9 (-70%)	1,268
FeeJuice:set_portal	8.58 (+11%)	1,208
Token:constructor	255 (+1%)	10,758
FPC:constructor	71.7 (+5%)	7,939
FeeJuice:check_balance	36.0 (+1%)	1,093
Token:mint_public	⚠️ 45.3 (-83%)	2,293
Token:assert_minter_and_mint	⚠️ 254 (+393%)	1,551
AuthRegistry:set_authorized	34.6 (-23%)	543
FPC:prepare_fee	84.4 (-10%)	1,596
Token:transfer_public	⚠️ 13.7 (-52%)	8,779
FPC:pay_refund	39.4 (-8%)	2,098
Benchmarking:increment_balance	999 (-2%)	1,536
Token:_increase_public_balance	43.2 (-19%)	1,239
FPC:pay_refund_with_shielded_rebate	51.4	2,098

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.22	3.90	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.117 (+1%)	0.110	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2	17.9	31.2	59.8 (-1%)	114 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108	0.104	0.101	0.103 (-1%)	0.102 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (-1%)	26.4 (+2%)	44.2 (-1%)	82.7 (-1%)	167 (+3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (-1%)	0.107 (+2%)	0.106	0.102 (-1%)	0.104 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.1 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,416	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

[nventuro]

Thanks!