Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract guidelines #856

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add contract guidelines #856

merged 1 commit into from
Jun 15, 2023

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Jun 15, 2023 •
edited
Loading

Description

Adds an initial guideline for contract writing with references to tools and style-guide.

Closes #593.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@LHerskind LHerskind marked this pull request as ready for review June 15, 2023 11:10
Maddiaa0
Maddiaa0 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maddiaa0 Maddiaa0 enabled auto-merge (squash) June 15, 2023 11:13
@Maddiaa0 Maddiaa0 merged commit df5a045 into master Jun 15, 2023
@Maddiaa0 Maddiaa0 deleted the lh/593-contract-style-guide branch June 15, 2023 11:15
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

@rahul-kothari rahul-kothari Awaiting requested review from rahul-kothari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General Contract Cleanup + Write out style guide
2 participants
@LHerskind @Maddiaa0