feat(avm)!: remove tag in NOT

[fcarreiro]

Case study to see how it goes.

[fcarreiro]

• feat(avm)!: remove tag in NOT #8606 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 240 (+446%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 298 (-39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,720	1,537	700	727 (-3%)	772 (+1%)
proof_construction_time_sha256_30_ms	11,936	3,174 (+1%)	1,420 (+2%)	1,438 (+1%)	1,475 (+1%)
proof_construction_time_sha256_100_ms	45,255	12,089 (+3%)	5,477 (+2%)	5,465 (+1%)	5,441 (+2%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,525	416	198 (-1%)	233 (+2%)	265 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,630	1,499	673	733 (+1%)	748 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,756	97,654	186,512
l1_rollup_execution_gas	821,874	1,558,180	3,348,473
l2_block_processing_time_in_ms	263 (+1%)	454	816 (-3%)
l2_block_building_time_in_ms	9,123 (-1%)	18,003	36,431
l2_block_rollup_simulation_time_in_ms	9,122 (-1%)	18,002	36,431
l2_block_public_tx_process_time_in_ms	7,764 (-1%)	16,610	34,942

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,192	4,080
node_database_size_in_bytes	14,246,128	18,243,824
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	69.5	374 (-1%)	20,951	44,933	N/A
private-kernel-inner	138 (-1%)	681 (-5%)	71,774	45,067	N/A
private-kernel-reset-tiny	351 (+13%)	683 (-1%)	64,265	44,922	N/A
private-kernel-tail	149 (-1%)	129 (-1%)	50,547	57,178	N/A
base-parity	6.07	N/A	160	96.0	N/A
root-parity	35.8	N/A	73,964	96.0	N/A
base-rollup	2,068	N/A	189,128	664	N/A
block-root-rollup	42.2	N/A	58,217	2,448	N/A
public-kernel-setup	84.9	N/A	114,433	79,670	N/A
public-kernel-app-logic	97.6	N/A	114,251	79,670	N/A
public-kernel-tail	567	N/A	487,098	16,414	N/A
private-kernel-reset-small	287	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	791 (+1%)	596 (-1%)	446,385	1,825	N/A
public-kernel-teardown	84.2	N/A	114,697	79,670	N/A
merge-rollup	20.3	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	102,637

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	343 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.2
MultiCallEntrypoint:entrypoint	1,920	11,731	420 (-2%)
FeeJuice:deploy	1,376	11,731	383
SchnorrAccount:constructor	1,312	11,731	63.9 (-1%)
SchnorrAccount:entrypoint	2,336	11,731	370
FeeJuice:claim	1,344	11,731	32.9 (-5%)
Token:privately_mint_private_note	1,280	11,731	76.2 (+3%)
FPC:fee_entrypoint_public	1,344	11,731	21.0 (-5%)
Token:transfer	1,312	11,731	192 (+3%)
Benchmarking:create_note	1,344	11,731	76.4 (+1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.2 (-13%)
Token:unshield	1,376	11,731	508 (+5%)
FPC:fee_entrypoint_private	1,376	11,731	678 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	42.9	1,171
FeeJuice:set_portal	10.2 (+6%)	1,148
Token:constructor	261 (-4%)	7,308
FPC:constructor	45.3 (-7%)	4,741
FeeJuice:check_balance	36.9	998
Token:mint_public	⚠️ 240 (+446%)	2,086
Token:assert_minter_and_mint	⚠️ 298 (-39%)	1,403
AuthRegistry:set_authorized	46.0 (+24%)	501
FPC:prepare_fee	64.2 (+3%)	1,333
Token:transfer_public	21.7 (+10%)	5,479
FPC:pay_refund	37.8 (-8%)	1,837
Benchmarking:increment_balance	983	1,529
Token:_increase_public_balance	38.8 (-2%)	1,162
FPC:pay_refund_with_shielded_rebate	48.4 (-5%)	1,841

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.573 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21 (+1%)	3.89 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.115 (+1%)	0.109 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+3%)	18.0 (-4%)	31.6 (+2%)	60.3 (+1%)	113 (-4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+3%)	0.105 (-4%)	0.103 (+2%)	0.104 (+1%)	0.102 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4 (+2%)	26.4 (+2%)	44.9 (-5%)	83.6 (+2%)	161 (-5%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (+2%)	0.107 (+2%)	0.103 (-10%)	0.104 (+2%)	0.103 (-4%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.3 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,430	668,302

Transaction size based on fee payment method

| Metric | |
| - | |