Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Uniswap designated caller #876

Closed
1 task done
Tracked by #843
LHerskind opened this issue Jun 19, 2023 · 0 comments · Fixed by #901
Closed
1 task done
Tracked by #843

feat: Uniswap designated caller #876

LHerskind opened this issue Jun 19, 2023 · 0 comments · Fixed by #901
Assignees
@rahul-kothari
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 19, 2023 •
edited
Loading

Add designated caller as mentioned in #843 to the Uniswap flow, ensuring that only Uniswap portal can spend initiate the consumption of the input asset withdraw on asset portal.

A successful implementation will ensure that:

  • Test abusing that designated is not used right now:
    • Consume the message first, making it impossible to execute the swap
    • Fix the below and see that same test will reject initial consumption by other party
  • Include uniswap address in message sent to asset portal as "designated caller"

Depends on
Preview Give feedback
  1. feat: Designated caller asset contract/portal #877
    feature
    rahul-kothari
@LHerskind LHerskind added this to A3 Jun 19, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 19, 2023
@LHerskind LHerskind mentioned this issue Jun 19, 2023
Closed
@LHerskind LHerskind added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Jun 19, 2023
This was referenced Jun 21, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 23, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add designated caller on uniswap portal AztecProtocol/aztec-packages
2 participants
@LHerskind @rahul-kothari