Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error clearly if incompatible Node versions are used #909

Closed
ludamad opened this issue Jun 26, 2023 · 3 comments · Fixed by #1053
Closed

Error clearly if incompatible Node versions are used #909

ludamad opened this issue Jun 26, 2023 · 3 comments · Fixed by #1053
Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. good first issue Good for newcomers

Comments

@ludamad
Copy link
Collaborator

ludamad commented Jun 26, 2023

Currently, if Node 14 is used it will seem to go far then fail at e.g. the first buffer.at. Having an explicit environment/ version check and error would work well, perhaps in a global scope

if not node >= 18
     throw error giving instructions on how to do `nvm use 18`
     Optionally even explain what would happen (some stuff would work others fail etc) if not heeded
@spalladino
Copy link
Collaborator

It's probably cleaner to set the node version in the engine field of the package json. See https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines.

@ludamad
Copy link
Collaborator Author

ludamad commented Jun 26, 2023

If we feel the message won't get missed that seems best

@ludamad ludamad added good first issue Good for newcomers A-internal-devex Area: Relates to the devex of internal teams building Aztec. labels Jul 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 13, 2023
@ludamad
Copy link
Collaborator Author

ludamad commented Jul 13, 2023

Closed by @Orloaft with the engine >= 18 approach

@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants