Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not throw when cannot propose #9315

Open
Tracked by #9261
just-mitch opened this issue Oct 21, 2024 · 0 comments
Open
Tracked by #9261

chore: do not throw when cannot propose #9315

just-mitch opened this issue Oct 21, 2024 · 0 comments
Assignees

Comments

@just-mitch
Copy link
Collaborator

just-mitch commented Oct 21, 2024

See comment in L1Publisher

  public async canProposeAtNextEthBlock(archive: Buffer): Promise<[bigint, bigint]> {
    // FIXME: This should not throw if unable to propose but return a falsey value, so
    // we can differentiate between errors when hitting the L1 rollup contract (eg RPC error)
    // which may require a retry, vs actually not being the turn for proposing.
This was referenced Oct 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 28, 2024
@just-mitch just-mitch self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant