Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix ABI array/struct decoding #956

Merged
merged 5 commits into from
Jul 4, 2023
Merged

fix: Fix ABI array/struct decoding #956

merged 5 commits into from
Jul 4, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jul 4, 2023 •
edited
Loading

Description

Came out of Noir/aztec dogfooding. Could not return an array from a view function. Gets rid of any's

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad ludamad changed the title fix: Fix ABI array decoding fix: Fix ABI array/struct decoding Jul 4, 2023
sirasistant
sirasistant approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ludamad ludamad enabled auto-merge (squash) July 4, 2023 09:54
@ludamad ludamad merged commit 404c3f8 into master Jul 4, 2023
@ludamad ludamad deleted the adam/fix-abi-array-decoding branch July 4, 2023 10:03
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirasistant sirasistant sirasistant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @sirasistant