feat: recursive verifier for decider and last folding proof #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maramihali
commented
Nov 4, 2024
| // these public inputs by turning proof into witnesses and calling set_public on each witness | ||
| auto num_public_inputs = static_cast<uint32_t>(static_cast<uint256_t>(proof.mega_proof[1])); | ||
| vinfo("Number of public inputs BEFORE subtracting stuff in mega proof: ", num_public_inputs); | ||
| num_public_inputs -= bb::AGGREGATION_OBJECT_SIZE; // don't add the agg object |
There was a problem hiding this comment.
My understanding is that, at least atm, there are no DATABUS commitments anymore at this stage
ledwards2225
approved these changes
Nov 4, 2024
Maddiaa0
pushed a commit
that referenced
this pull request
Nov 6, 2024
Construct the _hiding_ circuit, which recursively verifies the last folding proof and the decider proof in Client IVC and amend the e2e prover accordingly. The ClientIVC proof becomes a mega proof for the hiding circuit and a goblin proof which simplifies the work required to transform this in a zero knowledge proof.
|
There might be a need to add some kernel-circuit specific stuff. E.g. to check the final stack (inside the public input of the last kernel circuit instance) is empy as done in the seal circuit here: |
|
Thanks, created an issue for this! AztecProtocol/barretenberg#1156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct the hiding circuit, which recursively verifies the last folding proof and the decider proof in Client IVC and amend the e2e prover accordingly. The ClientIVC proof becomes a mega proof for the hiding circuit and a goblin proof which simplifies the work required to transform this in a zero knowledge proof.